fix: address PR #184 review feedback#196
Merged
leonvanzyl merged 1 commit intoAutoForgeAI:masterfrom Feb 15, 2026
Merged
Conversation
Collaborator
|
Thanks for the clean follow-up, @CaitlynByrne! The stricter select option validation and spurious options rejection look great. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feature_request_human_inputfield schema inmcp_server/feature_mcp.py, addressing review feedback from feat: add blocked for human input feature #184Changes
selectfield must be a dict with non-emptyvalueandlabelstringsoptionsare now rejected with a clear errorAlready addressed in master
The other two items from the review were already fixed before merge:
handleGraphNodeClickalready includesneeds_human_input(App.tsx:130-135)needs_human_input(App.tsx:249)Test plan
feature_request_human_inputwith a select field missingvalue/labelon options — should return erroroptionson a non-select field type — should return errorruff check .— passes🤖 Generated with Claude Code